Allow media type to be specified in release asset upload #1102
Conversation
Update UploadOptions with a MediaType field. If the MediaType is provided to UploadReleaseAsset it will take precedence over the type retrieved from looking at the file extension. The complete order of precedence is: - MediaType in UploadOptions - media type from file extension - default media type, application/octet-stream Update unit tests to test the order of precedence, default value and that the Content-Type header is actually set in the upload request.
googlebot
added
the
cla: yes
There was a problem hiding this comment.
Very nice, @aidenkeating! I like this a lot! Thank you for doing this.
LGTM.
Awaiting second LGTM before merging.
|
For other Gophers watching, @aidenkeating has taken advantage of a cool feature of the JSON Marshaling machinery... this doc says: Since we don't want Thank you, @gauntface! |
|
@gmlewis @gauntface Thanks for the review, really appreciated! I should have documented why |
|
No worries at all, @aidenkeating! This repo attracts a lot of new-to-Go developers since @willnorris laid an excellent foundation and maintained excellent consistency throughout the large API surface... so I try to remember this when anyone ventures into less-frequently-used language constructs... and yours is a great example. Thanks again for the PR! |
Update UploadOptions with a MediaType field. If the MediaType is
provided to UploadReleaseAsset it will take precedence over the type
retrieved from looking at the file extension. The complete order of
precedence is:
Update unit tests to test the order of precedence, default value and
that the Content-Type header is actually set in the upload request.